Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing SqlServer, and SqlClient tests #5057

Closed
radical opened this issue Jul 24, 2024 · 3 comments · Fixed by #5539
Closed

Failing SqlServer, and SqlClient tests #5057

radical opened this issue Jul 24, 2024 · 3 comments · Fixed by #5539
Labels
area-integrations Issues pertaining to Aspire Integrations packages disabled-tests testing ☑️

Comments

@radical
Copy link
Member

radical commented Jul 24, 2024

Update: The tests have been updated to work around this issue. But once the image is fixed, that should be reverted.


Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=753141
Build error leg or test failing: Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.WorkItemExecution
Pull request: #5043

This is always failing on CI now.

Log trails with:

[testcontainers.org 00:09:47.16] Execute "/opt/mssql-tools/bin/sqlcmd -Q SELECT 1;" at Docker container b1bad4065fe2
[testcontainers.org 00:09:47.22] Execute "/opt/mssql-tools/bin/sqlcmd -Q SELECT 1;" at Docker container 122d54403432
[testcontainers.org 00:09:47.22] Execute "/opt/mssql-tools/bin/sqlcmd -Q SELECT 1;" at Docker container 5dc1ce5edf1a
Aborting test run: test run timeout of 600000 milliseconds exceeded.

Also, Aspire.Microsoft.Data.SqlClient.Tests (log) is failing.

cc @eerhardt @joperezr

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jul 24, 2024
radical added a commit to radical/aspire that referenced this issue Jul 24, 2024
radical added a commit to radical/aspire that referenced this issue Jul 24, 2024
@radical radical changed the title Failing tests Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests Failing SqlServer, and SqlClient tests Jul 24, 2024
@radical
Copy link
Member Author

radical commented Jul 24, 2024

@radical radical added disabled-tests and removed blocking-clean-ci Blocking a green CI labels Jul 24, 2024
@radical
Copy link
Member Author

radical commented Jul 24, 2024

The tests are not really "disabled", but a workaround has been applied. I'm adding disabled-tests label here just so it can be tracked as a TODO.

@eerhardt eerhardt mentioned this issue Aug 9, 2024
@eerhardt
Copy link
Member

eerhardt commented Aug 9, 2024

@radical - can this be closed? We worked around the issue.

@radical radical closed this as completed Aug 9, 2024
radical pushed a commit that referenced this issue Sep 4, 2024
updates Testcontainers to the latest version `3.10.0`. This version includes a fix for the regression/changes made in the latest MSSQL Docker image (microsoft/mssql-docker#892). The recently added workaround (#5057, #5058) is no longer necessary.

Fixes #5057
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages disabled-tests testing ☑️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants