Skip to content

Harden xunit-reporter.py against hangs in upload_blob #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
MattGal opened this issue Jul 13, 2020 · 2 comments
Closed
2 tasks

Harden xunit-reporter.py against hangs in upload_blob #5783

MattGal opened this issue Jul 13, 2020 · 2 comments
Assignees

Comments

@MattGal
Copy link
Member

MattGal commented Jul 13, 2020

  • This issue is blocking
  • This issue is causing unreasonable pain

As noted in this PR: dotnet/runtime#39153
It seems that our storage client options are hitting Azure/azure-sdk-for-python#11437 .

  • We might be able to work around this by upping the Helix azure-storage-blob version to 12.3.2 from 12.0.0 (that'd be a change in dotnet-helix-machines)
  • Otherwise we should look into providing a timeout mechanism here for retries, as the file in question was actually quite small and if the upload_blob() call hadn't hung a retry would have been quite fast.
@MattGal
Copy link
Member Author

MattGal commented Aug 19, 2020

@AlitzelMendez can this be closed? If it's merged in Arcade for this long it's in use.

@AlitzelMendez
Copy link
Member

yes, it is already merged. closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants