Skip to content

Commit 4eafe66

Browse files
[build] set %(Kind) for PushManifestToBuildAssetRegistry (#10088)
Context: https://github.com/dotnet/arcade/blob/79ecdf3ef50e5e8e9d2b02e7113ec37c4219eeb5/src/Microsoft.DotNet.Build.Manifest/BuildModelFactory.cs#L95 Builds on main/release branches fail with: build-tools\create-packs\Directory.Build.targets(175,5): error : Missing 'Kind' property on artifact D:\a\_work\1\a\nuget-signed\Microsoft.Android.Ref.36.36.0.0-ci.main.72.nupkg. Possible values are 'Blob', 'PDB', 'Package'. In f2eea99, we updated `Microsoft.DotNet.Build.Tasks.Feed` which seems to have caused this issue: * Microsoft.DotNet.Build.Tasks.Feed: from 9.0.0-beta.24408.2 to 10.0.0-beta.25223.119 To fix this, set `%(Kind)=Package` for `.nupkg` files and `%(Kind)=Blob` for everything else.
1 parent 0a8c006 commit 4eafe66

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build-tools/create-packs/Directory.Build.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@
153153
<Error Condition="Exists($(AssetManifestPath))" Text="The manifest file '$(AssetManifestPath)' already exists." />
154154

155155
<ItemGroup>
156-
<ItemsToPush Include="$(OutputPath)*.nupkg" />
156+
<ItemsToPush Include="$(OutputPath)*.nupkg" Kind="Package" />
157157
<WorkloadArtifacts Include="$(OutputPath)*.zip" />
158-
<ItemsToPush Include="@(WorkloadArtifacts)" PublishFlatContainer="true" RelativeBlobPath="android/$(AndroidPackVersionLong)/%(Filename)%(Extension)" />
158+
<ItemsToPush Include="@(WorkloadArtifacts)" PublishFlatContainer="true" RelativeBlobPath="android/$(AndroidPackVersionLong)/%(Filename)%(Extension)" Kind="Blob" />
159159
</ItemGroup>
160160

161161
<Error Condition="'@(ItemsToPush)' == ''" Text="No packages to push." />

0 commit comments

Comments
 (0)