Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to save models #85

Closed
interesaaat opened this issue Jun 24, 2019 · 7 comments
Closed

Add functionality to save models #85

interesaaat opened this issue Jun 24, 2019 · 7 comments

Comments

@interesaaat
Copy link
Contributor

This will probably require a custom save logic or hooks into JIT save.

@mdabros
Copy link

mdabros commented Jun 27, 2019

@interesaaat Will this include save/load of the models using the ONNX format?

@interesaaat
Copy link
Contributor Author

@mdabros that may require some work. Apparently ONNX support in libTorch is limited for the moment. My hope is that in future release they will provide the torch.onnx.export functionality also in libTorch. If they don't we will have to write our own to-onnx-exporter.

@mdabros
Copy link

mdabros commented Jun 28, 2019

I see, that makes it more complicated. I was hoping the functionality was already there in libTorch. I hope they will add it soon. ONNX support in TorchSharp would really help make it a perfect choice for developing deep learning models for production. But I guess it is a separate issue from this one then.

@interesaaat
Copy link
Contributor Author

I totally agree. Maybe we can open an issue on the main PyTorch repo? Actually let me ask on the PyTorch's slack channel.

@dsyme
Copy link
Contributor

dsyme commented Jun 3, 2020

This is covered by #146

@dsyme dsyme closed this as completed Jun 3, 2020
@nietras
Copy link
Contributor

nietras commented Jun 4, 2020

@dsyme does #146 include onnx support (save as)?

@dsyme
Copy link
Contributor

dsyme commented Jun 15, 2020

@dsyme does #146 include onnx support (save as)?

It's not mentioned there - I'll add it - I presume it's a pre-requisite. If you'd like to contribute a PR for this that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants