-
-
Notifications
You must be signed in to change notification settings - Fork 175
Latest F# compiler warns on autogenerated Version.fs #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Same here fwiw:
CA2243 looks like a Roslyn analyzer, so I don't think it would run on F# code anyway |
Thanks for the fix! @AArnott What's the release process for this? I can of course work around the bug, but last night Dependabot's automatic PRs became blocked in most of my repos when they attempted to upgrade the .NET SDK. Would it be easy to cut a release of Nerdbank.GitVersioning? |
@Smaug123 You can always consume our CI builds as described here. If you need the package on nuget.org, I could ship a 3.8 pre-release to nuget.org. Or if you need a stable versioned release we could backport the fix to 3.7. |
If you could release the fix in some stable form, that would be great - it's hit pretty much every dotnet project I'm involved with at this point. |
Does the v3.8.38-alpha release not cut it? I'm a little hesitant to release the stable 3.8 version just because there aren't that many differences from 3.7 and I tend to wait till there's more value. |
fwiw I've updated a few projects to the 3.8 alpha and that's fixed the warnings for me |
Sorry for the noise - the alpha release does work for me, thanks. |
dotnet/fsharp#17871 made it a compile warning to specify an invalid #nowarn suppression in an F# file. The default Version.fs generated file contains a nowarn, CA2243 (sorry, I'm on my phone, will provide more details and possibly a fix when I get to a real computer).
I believe the correct fix is simply not to nowarn in the F# generated file.
The text was updated successfully, but these errors were encountered: