disable AwaitingTasksShouldNotInterfereAllocationResults for InProcess toolchain as it's flaky, contributes to #1925

adamsitnik · adamsitnik · commit 2787c88b3f64 · 2022-03-22T19:12:59.000+01:00
diff --git a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs
@@ -147,6 +147,11 @@ public class NonAllocatingAsynchronousBenchmarks
         [Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
         public void AwaitingTasksShouldNotInterfereAllocationResults(IToolchain toolchain)
         {
+            if (toolchain.IsInProcess)
+            {
+                return; // it's flaky: https://github.com/dotnet/BenchmarkDotNet/issues/1925
+            }
+
             AssertAllocations(toolchain, typeof(NonAllocatingAsynchronousBenchmarks), new Dictionary<string, long>
             {
                 { nameof(NonAllocatingAsynchronousBenchmarks.CompletedTask), 0 },

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,11 @@ public class NonAllocatingAsynchronousBenchmarks`
`147`	`147`	`[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]`
`148`	`148`	`public void AwaitingTasksShouldNotInterfereAllocationResults(IToolchain toolchain)`
`149`	`149`	`{`
	`150`	`+ if (toolchain.IsInProcess)`
	`151`	`+ {`
	`152`	`+ return; // it's flaky: https://github.com/dotnet/BenchmarkDotNet/issues/1925`
	`153`	`+ }`
	`154`	`+`
`150`	`155`	`AssertAllocations(toolchain, typeof(NonAllocatingAsynchronousBenchmarks), new Dictionary<string, long>`
`151`	`156`	`{`
`152`	`157`	`{ nameof(NonAllocatingAsynchronousBenchmarks.CompletedTask), 0 },`