-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Pre3] Boot config file name change (blazor.boot.json
👉 dotnet.boot.js
)
#35125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is still possibility of merging the config file completely into the dotnet.js (one of the underlaying scripts behind blazor.web(assembly).js |
I see ... so should this be held off until Preview 4? |
blazor.boot.json
👉 dotnet.boot.js
)blazor.boot.json
👉 dotnet.boot.js
)
I think I'm going to have to give you some links to look at so that we can see how the current guidance that relates to Alternatively, we could address it thus far for Pre3 and come back to it at Pre4 for further updates. It's up to you. If you want to work on it now for Pre3, I'll provide links to the current |
Give me the links, please. I'm curious why mention it so much in docs. It should be kind of an implementation detail, opaque to the users |
Here are the links to current mentions. Some of these will probably just require a simple rewording to factor out the offending " I'll number these, which might make it easier for you to respond on each ...
The following coverage isn't relevant because it's being versioned out at >=10.0 ... |
blazor.boot.json
👉 dotnet.boot.js
)blazor.boot.json
👉 dotnet.boot.js
)
@maraf ... This is next, unless you want to circle around to it later. I can write up Javier's declarative state persistence and circle back to this later. BTW -- Is this for Pre3 or Pre4? |
The rename is preview3. I'll decide this week (I hope Wed or Thu) if we want to merge the config file into dotnet.js. The powershell script makes me sad, because the actual schema of the config should be internal implementation detail. I think if we want to maintain it, we need to move it to aspnetcore or runtime and include it in some test, otherwise it's quite possible it is not accurate. |
I think so. I'll float a PR to address those mentions of WRT the script, one option is to version it out completely for 10.0 and open an issue to consider what should be done with it in the future, if anything (i.e., it might be permanently dropped). Should I proceed with that plan? |
Sounds good to me. I expect the script not to do the job completely even in 9.0 :/ |
Indeed! I'm not sure what to do about it. There are no reports of it failing to work, but that simply could be due to nobody on 🌍 trying to use it with 9.0. 😆 |
#35057 (comment)
The text was updated successfully, but these errors were encountered: