Skip to content

[Pre3] Boot config file name change (blazor.boot.json 👉 dotnet.boot.js) #35125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guardrex opened this issue Apr 2, 2025 · 10 comments · Fixed by #35176
Closed

[Pre3] Boot config file name change (blazor.boot.json 👉 dotnet.boot.js) #35125

guardrex opened this issue Apr 2, 2025 · 10 comments · Fixed by #35176

Comments

@guardrex
Copy link
Collaborator

guardrex commented Apr 2, 2025

#35057 (comment)

@maraf
Copy link
Member

maraf commented Apr 2, 2025

There is still possibility of merging the config file completely into the dotnet.js (one of the underlaying scripts behind blazor.web(assembly).js

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 2, 2025

I see ... so should this be held off until Preview 4?

@guardrex guardrex changed the title Boot file name change (blazor.boot.json 👉 dotnet.boot.js) Boot config file name change (blazor.boot.json 👉 dotnet.boot.js) Apr 2, 2025
@guardrex
Copy link
Collaborator Author

guardrex commented Apr 2, 2025

I think I'm going to have to give you some links to look at so that we can see how the current guidance that relates to blazor.boot.json needs to change. Since it's unclear what the final framework setup is going to be, perhaps we should wait to discuss it further until the Preview 4 era toward the end of this month.

Alternatively, we could address it thus far for Pre3 and come back to it at Pre4 for further updates. It's up to you. If you want to work on it now for Pre3, I'll provide links to the current blazor.boot.json content.

@maraf
Copy link
Member

maraf commented Apr 3, 2025

Give me the links, please. I'm curious why mention it so much in docs. It should be kind of an implementation detail, opaque to the users

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 3, 2025

@guardrex guardrex changed the title Boot config file name change (blazor.boot.json 👉 dotnet.boot.js) [Pre3] Boot config file name change (blazor.boot.json 👉 dotnet.boot.js) Apr 7, 2025
@guardrex
Copy link
Collaborator Author

guardrex commented Apr 8, 2025

@maraf ... This is next, unless you want to circle around to it later. I can write up Javier's declarative state persistence and circle back to this later.

BTW -- Is this for Pre3 or Pre4?

@maraf
Copy link
Member

maraf commented Apr 8, 2025

The rename is preview3. I'll decide this week (I hope Wed or Thu) if we want to merge the config file into dotnet.js.
Is that enough for you?

The powershell script makes me sad, because the actual schema of the config should be internal implementation detail. I think if we want to maintain it, we need to move it to aspnetcore or runtime and include it in some test, otherwise it's quite possible it is not accurate.

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 8, 2025

I think so. I'll float a PR to address those mentions of blazor.boot.json. I'll ping you on the PR.

WRT the script, one option is to version it out completely for 10.0 and open an issue to consider what should be done with it in the future, if anything (i.e., it might be permanently dropped). Should I proceed with that plan?

@maraf
Copy link
Member

maraf commented Apr 8, 2025

WRT the script, one option is to version it out completely for 10.0 and open an issue to consider what should be done with it in the future, if anything (i.e., it might be permanently dropped). Should I proceed with that plan?

Sounds good to me. I expect the script not to do the job completely even in 9.0 :/

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 8, 2025

not to do the job completely even in 9.0

Indeed! I'm not sure what to do about it. There are no reports of it failing to work, but that simply could be due to nobody on 🌍 trying to use it with 9.0. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants