Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

UrlChecker can exhaust sockets #62

Open
synercoder opened this issue Jul 19, 2017 · 0 comments
Open

UrlChecker can exhaust sockets #62

synercoder opened this issue Jul 19, 2017 · 0 comments

Comments

@synercoder
Copy link

In the current implementation of the UrlChecker for every check a new HttpClient is created. This can cause problems.

On MSDN it is stated under the remarks section:

HttpClient is intended to be instantiated once and re-used throughout the life of an application. Instantiating an HttpClient class for every request will exhaust the number of sockets available under heavy loads. This will result in SocketException errors.

Also more information about this issue can be found here: https://aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/

I will try to create a minimal verifiable test project to demonstrate the problem soon, as well as perhaps a pull request to fix it. I am currently at work and don't have the time to do that now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant