Skip to content

Commit 6595c42

Browse files
committed
auto merge of rust-lang#7520 : alexcrichton/rust/update-compiletest, r=pcwalton
Also marks them with `#[deny(warnings)]` (I think they're both only ever really built past stage1)
2 parents f115944 + 8552a74 commit 6595c42

File tree

14 files changed

+30
-60
lines changed

14 files changed

+30
-60
lines changed

mk/tools.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ $$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_LIBRUSTPKG_$(4)): \
5050
$$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_EXTRALIB_$(4)) \
5151
$$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_LIBRUSTC_$(4))
5252
@$$(call E, compile_and_link: $$@)
53-
$$(STAGE$(1)_T_$(4)_H_$(3)) -o $$@ $$< && touch $$@
53+
$$(STAGE$(1)_T_$(4)_H_$(3)) $$(WFLAGS_ST$(1)) -o $$@ $$< && touch $$@
5454

5555
$$(TBIN$(1)_T_$(4)_H_$(3))/rustpkg$$(X_$(4)): \
5656
$$(DRIVER_CRATE) \

src/compiletest/common.rs

-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use core::prelude::*;
12-
1311
#[deriving(Eq)]
1412
pub enum mode {
1513
mode_compile_fail,

src/compiletest/compiletest.rs

+12-24
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,16 @@
1111
#[crate_type = "bin"];
1212

1313
#[allow(non_camel_case_types)];
14+
#[allow(unrecognized_lint)]; // NOTE: remove after snapshot
15+
#[deny(warnings)];
1416

15-
#[no_core]; // XXX: Remove after snapshot
16-
#[no_std];
17+
extern mod extra;
1718

18-
extern mod core(name = "std", vers = "0.7");
19-
extern mod extra(name = "extra", vers = "0.7");
20-
21-
use core::prelude::*;
22-
use core::*;
19+
use std::os;
2320

2421
use extra::getopts;
2522
use extra::test;
2623

27-
use core::result::{Ok, Err};
28-
2924
use common::config;
3025
use common::mode_run_pass;
3126
use common::mode_run_fail;
@@ -42,13 +37,6 @@ pub mod runtest;
4237
pub mod common;
4338
pub mod errors;
4439

45-
mod std {
46-
pub use core::cmp;
47-
pub use core::str;
48-
pub use core::sys;
49-
pub use core::unstable;
50-
}
51-
5240
pub fn main() {
5341
let args = os::args();
5442
let config = parse_config(args);
@@ -98,8 +86,8 @@ pub fn parse_config(args: ~[~str]) -> config {
9886
run_ignored: getopts::opt_present(matches, "ignored"),
9987
filter:
10088
if !matches.free.is_empty() {
101-
option::Some(copy matches.free[0])
102-
} else { option::None },
89+
Some(copy matches.free[0])
90+
} else { None },
10391
logfile: getopts::opt_maybe_str(matches, "logfile").map(|s| Path(*s)),
10492
runtool: getopts::opt_maybe_str(matches, "runtool"),
10593
rustcflags: getopts::opt_maybe_str(matches, "rustcflags"),
@@ -148,8 +136,8 @@ pub fn log_config(config: &config) {
148136

149137
pub fn opt_str<'a>(maybestr: &'a Option<~str>) -> &'a str {
150138
match *maybestr {
151-
option::None => "(none)",
152-
option::Some(ref s) => {
139+
None => "(none)",
140+
Some(ref s) => {
153141
let s: &'a str = *s;
154142
s
155143
}
@@ -161,7 +149,7 @@ pub fn opt_str2(maybestr: Option<~str>) -> ~str {
161149
}
162150

163151
pub fn str_opt(maybestr: ~str) -> Option<~str> {
164-
if maybestr != ~"(none)" { option::Some(maybestr) } else { option::None }
152+
if maybestr != ~"(none)" { Some(maybestr) } else { None }
165153
}
166154

167155
pub fn str_mode(s: ~str) -> mode {
@@ -199,8 +187,8 @@ pub fn test_opts(config: &config) -> test::TestOpts {
199187
logfile: copy config.logfile,
200188
run_tests: true,
201189
run_benchmarks: false,
202-
save_results: option::None,
203-
compare_results: option::None
190+
save_results: None,
191+
compare_results: None
204192
}
205193
}
206194

@@ -268,7 +256,7 @@ pub fn make_test_name(config: &config, testfile: &Path) -> test::TestName {
268256
}
269257

270258
pub fn make_test_closure(config: &config, testfile: &Path) -> test::TestFn {
271-
use core::cell::Cell;
259+
use std::cell::Cell;
272260
let config = Cell::new(copy *config);
273261
let testfile = Cell::new(testfile.to_str());
274262
test::DynTestFn(|| { runtest::run(config.take(), testfile.take()) })

src/compiletest/errors.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use core::prelude::*;
12-
13-
use core::io;
11+
use std::io;
1412

1513
pub struct ExpectedError { line: uint, kind: ~str, msg: ~str }
1614

src/compiletest/header.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use core::prelude::*;
12-
1311
use common::config;
1412
use common;
1513

16-
use core::io;
17-
use core::os;
14+
use std::io;
15+
use std::os;
1816

1917
pub struct TestProps {
2018
// Lines that should be expected, in order, on standard out

src/compiletest/procsrv.rs

+3-5
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use core::prelude::*;
12-
13-
use core::os;
14-
use core::run;
15-
use core::str;
11+
use std::os;
12+
use std::run;
13+
use std::str;
1614

1715
#[cfg(target_os = "win32")]
1816
fn target_env(lib_path: &str, prog: &str) -> ~[(~str,~str)] {

src/compiletest/runtest.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use core::prelude::*;
12-
1311
use common::mode_run_pass;
1412
use common::mode_run_fail;
1513
use common::mode_compile_fail;
@@ -22,10 +20,10 @@ use procsrv;
2220
use util;
2321
use util::logv;
2422

25-
use core::io;
26-
use core::os;
27-
use core::uint;
28-
use core::vec;
23+
use std::io;
24+
use std::os;
25+
use std::uint;
26+
use std::vec;
2927

3028
pub fn run(config: config, testfile: ~str) {
3129
if config.verbose {

src/compiletest/util.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use core::prelude::*;
12-
1311
use common::config;
1412

15-
use core::io;
16-
use core::os::getenv;
13+
use std::io;
14+
use std::os::getenv;
1715

1816
pub fn make_new_path(path: &str) -> ~str {
1917

src/driver/driver.rs

-5
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
#[no_core];
12-
#[no_std];
13-
14-
extern mod core(name = "std", vers = "0.7");
15-
1611
#[cfg(rustpkg)]
1712
extern mod this(name = "rustpkg");
1813

src/librusti/rusti.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -667,8 +667,10 @@ mod tests {
667667
fn f() {}
668668
f()
669669
");
670+
}
670671

671-
debug!("simultaneous definitions + expressions are allowed");
672+
#[test]
673+
fn simultaneous_definition_and_expression() {
672674
run_program("
673675
let a = 3; a as u8
674676
");

src/librustpkg/api.rs

-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@ use package_id::*;
1414
use package_source::*;
1515
use version::Version;
1616

17-
use std::option::*;
1817
use std::os;
1918
use std::hashmap::*;
20-
use std::path::*;
2119

2220
/// Convenience functions intended for calling from pkg.rs
2321

src/librustpkg/messages.rs

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
use extra::term;
1212
use std::io;
13-
use std::result::*;
1413

1514
pub fn note(msg: &str) {
1615
pretty_message(msg, "note: ", term::color::GREEN, io::stdout())

src/librustpkg/package_source.rs

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use target::*;
1212
use package_id::PkgId;
1313
use std::path::Path;
14-
use std::option::*;
1514
use std::{os, run, str};
1615
use context::*;
1716
use crate::Crate;

src/librustpkg/util.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use std::{libc, os, result, str};
11+
use std::{os, result};
1212
use rustc::driver::{driver, session};
1313
use rustc::metadata::filesearch;
1414
use extra::getopts::groups::getopts;
@@ -379,6 +379,7 @@ pub fn link_exe(_src: &Path, _dest: &Path) -> bool {
379379
#[cfg(target_os = "freebsd")]
380380
#[cfg(target_os = "macos")]
381381
pub fn link_exe(src: &Path, dest: &Path) -> bool {
382+
use std::{libc, str};
382383
unsafe {
383384
do str::as_c_str(src.to_str()) |src_buf| {
384385
do str::as_c_str(dest.to_str()) |dest_buf| {

0 commit comments

Comments
 (0)