Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to get permanent buffs? #134

Open
steakscience opened this issue May 10, 2021 · 11 comments
Open

How to get permanent buffs? #134

steakscience opened this issue May 10, 2021 · 11 comments

Comments

@steakscience
Copy link

steakscience commented May 10, 2021

Example:

  • tome
  • agh shard
@steakscience
Copy link
Author

@jcoene Would you happen to know this?

@jacobxy
Copy link

jacobxy commented Jun 1, 2021

There are buffs generated and disappeared in the "CombatLog". The permanent buff is that only the generated state does not disappear!

@steakscience
Copy link
Author

@jacobxy How do you access CombatLog using Manta?

@jacobxy
Copy link

jacobxy commented Jun 1, 2021

func (c *Callbacks) OnCMsgDOTACombatLogEntry(fn func(*dota.CMsgDOTACombatLogEntry) error) {
c.onCMsgDOTACombatLogEntry = append(c.onCMsgDOTACombatLogEntry, fn)
}

@steakscience
Copy link
Author

@jacobxy Another question now that you're here:

Ability Upgrades seem to be skipping stats?

Example:
lvl 16 mirana takes Leap, lvl 17 mirana auto takes Stats, lvl 18 Mirana takes Moonlight Shadow

the parser will output this:
[..., lvl 16 leap, lvl 17 moonlight shadow]

Any way to work around this?

@jacobxy
Copy link

jacobxy commented Jun 1, 2021

I don't know how to write your parsing process, so I can't judge whether there is a problem. At present, the data I parse doesn't have such a problem.

@steakscience
Copy link
Author

@jacobxy We are writing it like this:

for level, ability := range player.GetAbilityUpgrades() {
	matchData.Players[index].AbilityUpgrades = append(matchData.Players[index].AbilityUpgrades, AbilityData{
		Level:        level,
		AbilityIndex: ability,
	})	
}

@jacobxy
Copy link

jacobxy commented Jun 1, 2021

It seems that this interface is post game data. At present, the return is an array, so it is impossible to jump the output level, because the data has the frame number of upgrade time, which needs to be combined with the player's level at that time, and the game process data needs to be analyzed.

@steakscience
Copy link
Author

I see, how would you recommend fetching this data instead?

@jacobxy
Copy link

jacobxy commented Jun 1, 2021

One of the methods of this library is to obtain process data by parsing DEM video files.

@steakscience
Copy link
Author

@jacobxy Thank you! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants