Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search feature #16

Open
chblw opened this issue Oct 6, 2018 · 12 comments
Open

Search feature #16

chblw opened this issue Oct 6, 2018 · 12 comments

Comments

@chblw
Copy link
Member

chblw commented Oct 6, 2018

Search presently directs request to Google Search. There might be better options, like dynamic searching for a static website. For example, hugo-lunr or others. Can someone investigate what open sourced solutions are commonly used ?

@stecaron
Copy link
Member

stecaron commented Oct 6, 2018

Good point @chblw ! @AntoineButeau do you have an opinion on that?

@AntoineButeau
Copy link
Contributor

Yes its better to setup static search on the site.
I can do it if you want.

@stecaron
Copy link
Member

stecaron commented Oct 6, 2018

@AntoineButeau maybe you can add it to the disqus branch if it is not too complex?

The PR #15 is already active so @samperochkin maybe we should wait little bit before making the merge.

@AntoineButeau
Copy link
Contributor

Yep should not be that long. working on it

@AntoineButeau
Copy link
Contributor

Meh it's a bit harder than I thought if we want to make the search page nice.
I would merge the PR and start an other one.

@AntoineButeau
Copy link
Contributor

For search we have multiple options https://gohugo.io/tools/search/
Hugo lunr, Fuse.js, elastic search or Algolia.
My two preferred options are Algolia and Fuse.js as they are easier to setup.
My fav one is Algolia since I used it in the past and they provide good resources, easier to maintain, easier to configure and to modify the UI of the search.

Once we decide on the search provider I'll create the search index and the search page.

@chblw @stecaron OK with Algolia?

@chblw
Copy link
Member Author

chblw commented Oct 6, 2018

Algolia sound nice and looks free for open sourced or non-profit orgs. I'd be ok with that !

@stecaron
Copy link
Member

stecaron commented Oct 7, 2018

You're the man But, I trust you ! Let's give a shot with Algolia

@AntoineButeau
Copy link
Contributor

Sounds good for Algolia.
Target implementation in 2 weeks.

@AnnieDeshaies
Copy link
Collaborator

Est-ce c'est une issue qui a mené quelque part? Hugo-lunr me semble aussi facile a implementer. ?

@AntoineButeau
Copy link
Contributor

AntoineButeau commented Nov 3, 2019 via email

@AnnieDeshaies
Copy link
Collaborator

AnnieDeshaies commented Nov 3, 2019

Je peux regarder. En meme temps, je pense que les categories devraient etre dans des tags au lieu d'etre sous "categories". Pour les articles en tout cas, on les verrait mieux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants