-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shadcn components #154
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Instead of ignoring the |
I'm too thinking we should ignore the components from shad-cn, it will just be a pain to reformat them each time. |
We will only have to fix the linting errors once when someone adds a new 'shadcn component' to the project. Since 'shadcn' components is still someone else' s code and we are technically just copy pasting the components into the project, we should still make sure that code follows the project's eslint rules. Running |
any updates of still using shadcn? |
Fix conflicts and errors of your PR before we review again |
@Mathys-Gasnier I think we should probably open up another MR for this. It is blocking a lot of other developers from contributing. |
Description
add shad-cn components
Type of Change
note : there are some linting errors from the already pre-built shad-cn components , would recommend to disable folder that folder