Test failure in test/go-indentation-test.el

[manphiz]

ERT tests fail in test/go-indentation-test.el due to incorrect file path. The following patch should fix this (originally authored by Hilko Bengen [email protected]):

Index: go-mode.el/test/go-indentation-test.el
===================================================================
--- go-mode.el.orig/test/go-indentation-test.el
+++ go-mode.el/test/go-indentation-test.el
@@ -8,7 +8,7 @@
 (require 'go-mode)
 
 (ert-deftest go--indent-line ()
-  (dolist (file (directory-files (expand-file-name "testdata/indentation_tests/") t ".*\\.go$"))
+  (dolist (file (directory-files (expand-file-name "test/testdata/indentation_tests/") t ".*\\.go$"))
     (with-temp-buffer
       (go-mode)
       (insert-file-contents file)
@@ -19,7 +19,7 @@
 (ert-deftest go-dot-mod--indent-line ()
   (with-temp-buffer
     (go-dot-mod-mode)
-    (insert-file-contents "testdata/indentation_tests/go.mod")
+    (insert-file-contents "test/testdata/indentation_tests/go.mod")
     (let ((contents-before-indent (buffer-string)) (inhibit-message t))
       (indent-region (point-min) (point-max) nil)
       (should (string= contents-before-indent (buffer-string))))))

[dominikh]

I believe the tests were written under the assumption that tests would be batch-run from the test directory. I don't know what the idiomatic approach for ERT is here; I will have to look into it.