why is the output of version command "UNDEFINED"?

[RedemptionC]

timetrace/main.go

Line 13 in 564a621

var version = "UNDEFINED"

[dominikbraun]

Hi,

the source code itself does not know what version it is. Instead, the version number is injected when building the timetrace binary on a new release:

timetrace/.circleci/config.yml

Lines 76 to 78 in 564a621

	GOOS=linux GOARCH=amd64 go build \
	-v \
	-ldflags "-X main.version=${CIRCLE_TAG}" \

↑ This overwrites the version variable with the version stored in the $CIRCLE_TAG environment variable.

As a result, when running the version command from source, the output will be UNDEFINED - but when running the version command from a released binary, the actual version will be displayed.

Does this answer your question?

[RedemptionC]

Hi,

the source code itself does not know what version it is. Instead, the version number is injected when building the timetrace binary on a new release:

timetrace/.circleci/config.yml

Lines 76 to 78 in 564a621

	GOOS=linux GOARCH=amd64 go build \
	-v \
	-ldflags "-X main.version=${CIRCLE_TAG}" \

↑ This overwrites the version variable with the version stored in the $CIRCLE_TAG environment variable.

As a result, when running the version command from source, the output will be UNDEFINED - but when running the version command from a released binary, the actual version will be displayed.

Does this answer your question?

I installed timetrace using

sudo snap install timetrace --edge --devmode

and then I run timetrace version,it says:💡 timetrace version UNDEFINED
is this behavior reasonable?
or should I use other method to install,so that it can print proper version?

[dominikbraun]

Ah, I see. This is probably because the version information is not yet available in the Snap configuration. Snap directly builds timetrace from source.

Gonna create an issue for this :-)

[RedemptionC]

Ah, I see. This is probably because the version information is not yet available in the Snap configuration. Snap directly builds timetrace from source.

Gonna create an issue for this :-)

got it
thanks for your quick reply
But it seems there are no realease directly available to ubuntu 20.04 LTS user,say,using apt?

[dominikbraun]

Yes, there are no apt releases yet. In that case, you'd have to directly download the binary or run it in Docker.

[RedemptionC]

Yes, there are no apt releases yet. In that case, you'd have to directly download the binary or run it in Docker.

a binary is good for me
Thanks again :)

[dominikbraun]

I've created #171 for making timetrace available via apt in the future. 😄 Going to close this issue in turn, feel free to re-open it for further questions on this matter.

[RedemptionC]

I've created #171 for making timetrace available via apt in the future. Going to close this issue in turn, feel free to re-open it for further questions on this matter.

sure
love this project and I want to make some contribution to it
but currently I probably will focus on some golang-related issues