[Feature Request] Add option to close Layout Editor without visible indicator

[Sinneida]

Hi!
First of all, huge thanks for creating this extension, I always admire people who swiftly navigate through Gnome API in JS and create magic with it, despite working with JS/TS in my job for a few years, it still feels complicated. :)

Describe the feature you'd like
Currently when triggering Layout Editor the only option to close it by saving or discarding changes within it is to click on the indicator icon and pick proper option. I'd like to have an option to close it by clicking some keyboard button (Esc keys seems like a natural choice) to discard the changes and some other key to save my layout within editor, i.e. Enter key.

Additional context
None

[domferr]

Hey thank you for sharing this! I've already implemented such feature of pressing Esc key to cancel the layout editing, HOWEVER it turned out...it doesn't work! 😢 😆

The good news is that I've already implemented a bugfix which will be released soon 🔜. Meanwhile, may I ask you which GNOME version you are using? Because I noticed such feature not working on GNOME <= 44 only. Can you confirm you are on GNOME <= 44 as well?

I always admire people who swiftly navigate through Gnome API in JS and create magic with it, despite working with JS/TS in my job for a few years, it still feels complicated. :)

Thank you so much! Any help, especially from people working daily with JS/TS, would be much appreciated. Feel free to contribute whenever you want, I'd provide any help you may need 😎

[dzanotelli]

Same thoughts as Sinneida above, esc and enter support would be great.
I confirm esc is not working for me on Gnome 64 over Wayland, v15.0 of tiling shell.

[domferr]

Thank you @dzanotelli for your feedback!

[Sinneida]

Hi, sorry for late response, I've missed the notification from GitHub somehow. 😶
I have GNOME 47 over Wayland, extension version is v15.0.

Thank you so much! Any help, especially from people working daily with JS/TS, would be much appreciated. Feel free to contribute whenever you want, I'd provide any help you may need 😎

Thanks for the offer, I have on my personal roadmap to learn GJS, so in the future I'll be more helpful by creating a PR for my favorite extensions instead of just adding another issue to the pile 😅