Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of DIRT-T #35

Open
Solacex opened this issue Mar 13, 2019 · 3 comments
Open

Implementation of DIRT-T #35

Solacex opened this issue Mar 13, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Solacex
Copy link

Solacex commented Mar 13, 2019

class SVHN_MNIST_Model(nn.Module):

I noticed that the architecture of DIRT-T in salad is different from the setting in the original paper:
image

including the number of channels in hidden layers and the activation function(the original paper is LeakyReLU)

@stes
Copy link
Contributor

stes commented Mar 14, 2019

Hey @Solacex , yes you're right; actually all implementations currently using the same model, which is the one used in the Self-Ensembling paper by French et al.
This gives the SelfEnsemblingSolver potentially an unfair advantage when this architecture is used.

Would you be interested in implementing the DIRT-T model and submitting a PR? It would be interesting to see how results change when this model architecture is used.

@stes stes added the enhancement New feature or request label Mar 14, 2019
@stes
Copy link
Contributor

stes commented Mar 14, 2019

In case you're interested in implementing this, please directly change the code in https://github.com/domainadaptation/salad/blob/master/salad/models/digits/dirtt.py and call the resulting implementation SVHN_MNIST_DIRTTBaseline or similar.

Thanks a lot!

@Solacex
Copy link
Author

Solacex commented Mar 14, 2019

Hello, @stes
I am trying implementing DIRT-T, I will submit my pytorch implementation as you indicated once finished.
And I am so appreciated you that make and public such a good library, it helps me a lot!

@stes stes assigned stes and Solacex Mar 15, 2019
@stes stes added the help wanted Extra attention is needed label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants