components: Fix data-cy

dolthub · Mar 15, 2024 · ea51a11 · ea51a11
1 parent 7639fc9
commit ea51a11
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/packages/components/src/FormSelect/components/CustomOption.tsx b/packages/components/src/FormSelect/components/CustomOption.tsx
@@ -3,14 +3,19 @@ import React from "react";
 import { Option } from "../types";
 import css from "./index.module.css";
 
-export default function CustomOption<T, OptionType extends Option<T>>(props: {
+type Props<OptionType> = {
   data: OptionType;
-}) {
+  dataCyPrefix: string;
+};
+
+export default function CustomOption<T, OptionType extends Option<T>>(
+  props: Props<OptionType>,
+) {
   return (
     <span
       className={cx({ [css.withIconPath]: !!props.data.iconPath })}
       aria-label={String(props.data.value)}
-      data-cy={String(props.data.value)}
+      data-cy={`${props.dataCyPrefix}-${props.data.value}`}
     >
       {props.data.iconPath && (
         <img src={props.data.iconPath} alt={props.data.label} />

diff --git a/packages/components/src/FormSelect/components/Option.tsx b/packages/components/src/FormSelect/components/Option.tsx
@@ -13,7 +13,7 @@ export default function OptionComponent<
 >(props: OptionProps<OptionType, IsMulti>): JSX.Element {
   return (
     <components.Option {...props}>
-      <CustomOption data={props.data} />
+      <CustomOption data={props.data} dataCyPrefix="select-option" />
     </components.Option>
   );
 }
@@ -28,7 +28,7 @@ export function OptionForGroup<
       <FiCheck
         className={cx(css.check, { [css.checkInvisible]: !props.isSelected })}
       />
-      <CustomOption data={props.data} />
+      <CustomOption data={props.data} dataCyPrefix="select-option" />
     </components.Option>
   );
 }
diff --git a/packages/components/src/FormSelect/components/SingleValue.tsx b/packages/components/src/FormSelect/components/SingleValue.tsx
@@ -10,7 +10,7 @@ export default function SingleValueComponent<
 >(props: SingleValueProps<OptionType, IsMulti>): JSX.Element {
   return (
     <components.SingleValue {...props}>
-      <CustomOption data={props.data} />
+      <CustomOption data={props.data} dataCyPrefix="single-value" />
     </components.SingleValue>
   );
 }