Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sabre Raven appearing as normal Sabre #118

Open
seskritt opened this issue Oct 11, 2023 · 4 comments
Open

Sabre Raven appearing as normal Sabre #118

seskritt opened this issue Oct 11, 2023 · 4 comments
Assignees
Labels

Comments

@seskritt
Copy link

The Sabre Raven is appearing with the name and image of a normal Sabre.

sabre-raven

@peter-dolkens
Copy link
Member

Will add this to my list to look at - am in the middle of moving half way around the world, so may be after the holidays, but thanks for bringing to my attention.

@peter-dolkens peter-dolkens self-assigned this Nov 20, 2023
@seskritt
Copy link
Author

Will add this to my list to look at - am in the middle of moving half way around the world, so may be after the holidays, but thanks for bringing to my attention.

When I have a some free time I'll take a stab at fixing it myself. Thank you for the update and good luck with your big move!

@seskritt
Copy link
Author

The bug was caused by the name matching in the ParseShip method. Since it checks if a shipMatrix name exists in the hangar ship's name, "Sabre" was coming up as a match for "Sabre Raven". I've submitted a pull request #121

@mbetzer
Copy link

mbetzer commented Jan 23, 2024

I opened a new issue (#124), but it might be the same as this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants