Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting caching #70

Open
gunaso opened this issue Mar 5, 2020 · 7 comments
Open

Rate limiting caching #70

gunaso opened this issue Mar 5, 2020 · 7 comments
Assignees
Labels
enhancement A good idea for new feature. help-wanted We could use someone's help with this problem! question Just a simple question.

Comments

@gunaso
Copy link

gunaso commented Mar 5, 2020

Does rate limiting caching only prevents you to do more requests while you are not able to? Or waits until you have permission to make more requests and keeps going with the script?

@dolejska-daniel dolejska-daniel self-assigned this Mar 5, 2020
@dolejska-daniel dolejska-daniel added the question Just a simple question. label Mar 5, 2020
@dolejska-daniel
Copy link
Owner

Hello, rate limiting as currently implemented raises exception when unable to send request. But I can see usage when this could be inappropriate.

@gunaso
Copy link
Author

gunaso commented Mar 5, 2020

Are you thinking on implementing s system where instead of raising an exception, it stays in standby until the key is able to send requests again?

@dolejska-daniel
Copy link
Owner

It could be done..

@elreco
Copy link
Contributor

elreco commented Jul 16, 2020

I will need this feature, if you didn't start anything I guess I will work on it :)

@elreco
Copy link
Contributor

elreco commented Jul 16, 2020

We should be able to set variables when initializing the API with :

x request(s) per x seconds
exemple : LeagueAPI::SET_KEY_LIMIT_1 => 20_1 for 20 request(s) per 1 second

AND

x request(s) per x minutes
exemple : LeagueAPI::SET_KEY_LIMIT_1 => 20_1 for 100 request(s) per 2 minutes

depending on the given api key limitations.

@dolejska-daniel
Copy link
Owner

dolejska-daniel commented Jul 17, 2020

@elreco why set limits during initialization? Key limits for each resource can be loaded after their first request.

@elreco
Copy link
Contributor

elreco commented Jul 17, 2020

@dolejska-daniel you are right

@dolejska-daniel dolejska-daniel added the enhancement A good idea for new feature. label Jan 8, 2021
@dolejska-daniel dolejska-daniel added the help-wanted We could use someone's help with this problem! label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A good idea for new feature. help-wanted We could use someone's help with this problem! question Just a simple question.
Projects
None yet
Development

No branches or pull requests

3 participants