Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for RTL Languages #246

Open
techana opened this issue May 22, 2023 · 1 comment · May be fixed by #249
Open

Fixes for RTL Languages #246

techana opened this issue May 22, 2023 · 1 comment · May be fixed by #249
Labels

Comments

@techana
Copy link

techana commented May 22, 2023

  1. Tags at the end of a page are aligned to the right in LTR langauges, such as English. This implies they should be aligned to the left in RTL languages, such as Arabic. To fix this, edit "style.css" as follows:
-  text-align: right;
+  text-align: end;
  1. If an LTR page shows two tags at the bottom, these two tags are separated by a comma ", ". But for RTL languages, the two tags are separated with an empty space only and the comma appears after the second tag! To fix this, edit "helper.php" as follows:
-        return implode(','.DOKU_LF.DOKU_TAB, $links);
+        return implode(', '.DOKU_LF, $links);
  1. When the user clicks on a tag and is directed to the showtag page prepared by the PageList plugin, the phrase "TAG" always appears in English regardless of the wiki language. Although, the correct translation for "TAG" is included in "lang.php" files under "lang" folder.
Klap-in added a commit that referenced this issue Aug 19, 2023
Klap-in added a commit that referenced this issue Aug 19, 2023
@Klap-in Klap-in linked a pull request Aug 19, 2023 that will close this issue
@Klap-in
Copy link
Member

Klap-in commented Aug 19, 2023

Thanks for your helpful examples! implemented in #249

@Klap-in Klap-in added the bug label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants