From d03dc37aa08f884b0b3fc414a385e5efa8dd1631 Mon Sep 17 00:00:00 2001 From: Alex Simons Date: Tue, 6 Apr 2021 05:47:33 -0500 Subject: [PATCH] Glass Pane Scrolling Fix (#54) * Trying to hack css * Think this works * Added other panes * Updated changelog and bumped version to v10.0.1 * Updated changelog * Fixed scrolling again * added changelog notes * Actually activating on startup finished --- CHANGELOG.md | 9 +++++++++ package.json | 4 ++-- src/NotificationService.ts | 2 +- src/StickerService.ts | 18 +++++++++++++++--- 4 files changed, 27 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a650641..ad02ec4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,14 @@ # Change Log +# 11.1.1 [Better Glass Pane Experience] + +- Fixed annoying background dragging in file tree. Be sure to re-install the wallpaper for this to take effect. + +| Before | After | +| --- | --- | +| ![Peek 2021-03-18 17-57](https://user-images.githubusercontent.com/15972415/111708429-d38e3300-8813-11eb-916c-bdbb05388c2f.gif) | ![Peek 2021-03-18 17-53](https://user-images.githubusercontent.com/15972415/111708430-d426c980-8813-11eb-84f5-960b0bb6673d.gif) | + + # 11.1.0 [Usability Updates] - Fixed all theme usability issues found in [#46](https://github.com/doki-theme/doki-theme-vscode/issues/46). diff --git a/package.json b/package.json index 54a966a..7090da8 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "displayName": "The Doki Theme", "description": "A bunch of themes with cute anime girls. Code with your waifu!", "publisher": "unthrottled", - "version": "11.1.0", + "version": "11.1.1", "license": "MIT", "icon": "Doki-Theme.png", "galleryBanner": { @@ -29,7 +29,7 @@ "Otaku" ], "activationEvents": [ - "onStartupFinish", + "onStartupFinished", "onCommand:doki-theme.doki.changelog", "onCommand:doki-theme.remove.sticker", "onCommand:doki-theme.theme.Maika", diff --git a/src/NotificationService.ts b/src/NotificationService.ts index b954ac1..c2bd2ea 100644 --- a/src/NotificationService.ts +++ b/src/NotificationService.ts @@ -3,7 +3,7 @@ import { VSCodeGlobals } from "./VSCodeGlobals"; import { attemptToGreetUser } from "./WelcomeService"; const SAVED_VERSION = "doki.theme.version"; -const DOKI_THEME_VERSION = "v11.1.0"; +const DOKI_THEME_VERSION = "v11.1.1"; export function attemptToNotifyUpdates(context: vscode.ExtensionContext) { const savedVersion = VSCodeGlobals.globalState.get(SAVED_VERSION); diff --git a/src/StickerService.ts b/src/StickerService.ts index 54d5c4a..876a071 100644 --- a/src/StickerService.ts +++ b/src/StickerService.ts @@ -35,14 +35,12 @@ function buildWallpaperCss({ .content, .monaco-select-box, .pane-header, - [id="workbench.view.explorer"] .monaco-list-rows, .minimap-decorations-layer, .xterm-cursor-layer, .decorationsOverviewRuler, .monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-breadcrumbs .breadcrumbs-control, .ref-tree, /* find usages */ .head, /* find usages */ - .monaco-split-view2>.monaco-scrollable-element>.split-view-container>.split-view-view .monaco-list-rows, .monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions { background-image: url('${wallpaperURL}') !important; @@ -56,7 +54,21 @@ function buildWallpaperCss({ background-color: #00000000 !important; } - + [id="workbench.view.explorer"] .monaco-list-rows, + [id="workbench.view.explorer"] .pane-header, + [id="workbench.view.explorer"] .monaco-pane-view, + [id="workbench.view.explorer"] .split-view-view, + [id="workbench.view.explorer"] .monaco-tl-twistie, + [id="workbench.view.explorer"] .monaco-icon-label-container, + .explorer-folders-view > .monaco-list > .monaco-scrollable-element > .monaco-list-rows, + .show-file-icons > .monaco-list > .monaco-scrollable-element > .monaco-list-rows, + .extensions-list > .monaco-list > .monaco-scrollable-element > .monaco-list-rows + { + background-color: #00000000 !important; + background-image: none !important; + border: none !important; + } + .monaco-icon-label-container { background: none !important; }