From 90767953a52ac2e2498cccca1f497f4c6df5764b Mon Sep 17 00:00:00 2001 From: glihm Date: Sat, 9 Nov 2024 09:14:15 -0600 Subject: [PATCH] docs: fix typo (n-06) (#2641) * docs: fix typo * docs: clarify syscall behavior --- crates/dojo/core/src/contract/components/upgradeable.cairo | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/dojo/core/src/contract/components/upgradeable.cairo b/crates/dojo/core/src/contract/components/upgradeable.cairo index 2ae357a3b7..e08a718d7f 100644 --- a/crates/dojo/core/src/contract/components/upgradeable.cairo +++ b/crates/dojo/core/src/contract/components/upgradeable.cairo @@ -50,8 +50,10 @@ pub mod upgradeable_cpt { ); assert(new_class_hash.is_non_zero(), Errors::INVALID_CLASS); - // Seems like the match doesn't catch the error is the entrypoint is - // not found. + // Currently - any syscall that fails on starknet - fails the transaction, and it won't + // be included in any block. + // The test runner does not simulate this, but instead simulates the future behavior + // when errors can be recovered from. match starknet::syscalls::library_call_syscall( new_class_hash, selector!("dojo_name"), [].span(), ) {