Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXVK 2.5.2 causes FPS drop due to shader issues #4537

Closed
RouatbiH opened this issue Dec 21, 2024 · 17 comments · Fixed by #4590
Closed

DXVK 2.5.2 causes FPS drop due to shader issues #4537

RouatbiH opened this issue Dec 21, 2024 · 17 comments · Fixed by #4590

Comments

@RouatbiH
Copy link

FPS go to 5 due to shader issue
I tested builds from actions and I found that this become happening after merging #4398

System information

  • GPU: NVIDIA GeForce GTX 1650
  • Driver: 32.0.15.6636
  • DXVK version: 2.5.2

Apitrace file(s)

logs + videos

@K0bin
Copy link
Collaborator

K0bin commented Dec 21, 2024

Could you please also tell us the name of the game? This is highly specific to one single game, we've tested dozens of games and didn't encounter this problem once.

@WinterSnowfall
Copy link
Contributor

Will definitely need to know what game this is.

How is the performance if you run it with DXVK_LOG_LEVEL=none?

@RouatbiH
Copy link
Author

Could you please also tell us the name of the game? This is highly specific to one single game, we've tested dozens of games and didn't encounter this problem once.

The game has been discontinued for years, and it is no longer officially playable. However, I am running it on a local private server that I developed myself.

Would you prefer that I close this issue for now? I can open a new one if I encounter a similar issue with another game in the future.

@RouatbiH
Copy link
Author

Will definitely need to know what game this is.

How is the performance if you run it with DXVK_LOG_LEVEL=none?

Still the same performance

@WinterSnowfall
Copy link
Contributor

Would you prefer that I close this issue for now? I can open a new one if I encounter a similar issue with another game in the future.

No, it's a genuine issue apparently, so we do want to look into it. @Blisto91 has found the game, so we'll see what we can do. It seems to hit the same validation that is needed by The Void, but it's affecting it negatively.

The character model for the robot doesn't seem to be rendered any longer, so it's not just a performance issue.

@RouatbiH
Copy link
Author

Would you prefer that I close this issue for now? I can open a new one if I encounter a similar issue with another game in the future.

No, it's a genuine issue apparently, so we do want to look into it. @Blisto91 has found the game, so we'll see what we can do. It seems to hit the same validation that is needed by The Void, but it's affecting it negatively.

The character model for the robot doesn't seem to be rendered any longer, so it's not just a performance issue.

Thank you for the update. I appreciate you looking into it. If you need any additional information or testing on my end, feel free to reach out. You can contact me on Discord: razrusheniye.

@Blisto91
Copy link
Contributor

No, it's a genuine issue apparently, so we do want to look into it. @Blisto91 has found the game, so we'll see what we can do.

Scratch that. I had only found a website for the game. Didn't know it was discontinued

@WinterSnowfall
Copy link
Contributor

@RouatbiH Please try this build: https://github.com/doitsujin/dxvk/actions/runs/12453032682/artifacts/2353129099 and let us know how it goes. The issue should be sorted now.

@RouatbiH
Copy link
Author

@RouatbiH Please try this build: https://github.com/doitsujin/dxvk/actions/runs/12453032682/artifacts/2353129099 and let us know how it goes. The issue should be sorted now.

Thank you for the build! I tested it, and the issue is resolved. I really appreciate your help.

@Blisto91
Copy link
Contributor

Blisto91 commented Jan 5, 2025

@RouatbiH Could i get you to dump the shaders of the game? We'd like to take a look at the offending ones that are causing trouble.
Just launch the game with DXVK_SHADER_DUMP_PATH= pointing to a empty folder you've created and do the usual thing with the game for this issue. Then archive the dumped shaders and attach them here.

@WinterSnowfall
Copy link
Contributor

@RouatbiH Please try this build: https://github.com/doitsujin/dxvk/actions/runs/12453032682/artifacts/2353129099

P.S.: You need to do that using this build or dxvk 2.5.1, otherwise the relevant shaders will be skipped.

@RouatbiH
Copy link
Author

RouatbiH commented Jan 5, 2025

@RouatbiH Could i get you to dump the shaders of the game? We'd like to take a look at the offending ones that are causing trouble. Just launch the game with DXVK_SHADER_DUMP_PATH= pointing to a empty folder you've created and do the usual thing with the game for this issue. Then archive the dumped shaders and attach them here.

Here is the link to the archived shaders:
shaders.zip

P.S.: You need to do that using this build or dxvk 2.5.1, otherwise the relevant shaders will be skipped.

The shaders were dumped using the build you provided (commit 86aa8ba).

@doitsujin
Copy link
Owner

doitsujin commented Jan 6, 2025

Hm, I ran all the shaders from that dump through our validation and they all pass. Did you reach the problematic portion of the game that time?

I also filed a PR to add more logging, a build can be found here:
https://github.com/doitsujin/dxvk/actions/runs/12638386009/artifacts/2391919527

This build should trigger the bug. Please run the game with that until you run into issues, and post the DXVK log afterwards.

@RouatbiH
Copy link
Author

RouatbiH commented Jan 7, 2025

Hm, I ran all the shaders from that dump through our validation and they all pass. Did you reach the problematic portion of the game that time?

Yes

This build should trigger the bug. Please run the game with that until you run into issues, and post the DXVK log afterwards.

https://drive.google.com/file/d/1mZhvJW0kgQ2vPeMDKFZSbryolOGQ4gw9/view?usp=sharing

@doitsujin
Copy link
Owner

Thanks, this confirms that we're reading out of bounds somewhere.

@WinterSnowfall
Copy link
Contributor

@RouatbiH Thank you for your patience and your support in narrowing down the problem. I am hoping we have a definitive fix for the issue now. Please try this build with the game: https://github.com/doitsujin/dxvk/actions/runs/12654635033/artifacts/2396592897 and let us know if it solves the issue you were seeing.

@RouatbiH
Copy link
Author

RouatbiH commented Jan 7, 2025

Thank you for the updated build! I tested it, and it's working perfectly now. I really appreciate your effort and the great work on this project. Keep up the fantastic work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment