Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to generate Dockerfiles by version + Github Action integration #16

Open
AbcSxyZ opened this issue Nov 21, 2021 · 1 comment
Open

Comments

@AbcSxyZ
Copy link
Contributor

AbcSxyZ commented Nov 21, 2021

I'm starting to think about a script to generate a Dockerfile for each Dogecoin Core release, and to have a way to update existing Dockerfiles/images when a template is edited, by using GitHub Action (GA) to automate Docker Hub tasks.
The goal here is to draft the script & the GA process.

The repository architecture would be the following, as defined in the related issue:

.
└── version
    ├── distro1
    │   └── Dockerfile
    └── distro2
        └── Dockerfile
└── version2
   ├── distro1
   ....

As I see it now, we can have 2 type of event :

GitHub change Docker Hub changes
push on release 1 version pushed, 1 image per distro 
update of templates all version updated, for all distros

By reading GA documentation, I think it can be possible to achieve something like that 🤞.

Should we update all Dockerfiles and images when a template is modified ? Docker Hub do not handle versioning for images, and changes can break related programs. Docker official images do not use a version strategy, but we may have change they don't.

I'm not sure how intensively GA should automate stuff. Do we try to do the publication of a new version with a workflow on Dogecoin Core called on releases ? Depend on the previous question, but do we automate update of templates (and Dockerfiles), GA propagating the change & committing automatically, or should do a PR ? Alternatively, do we let human run the script, creating locally new files & PR the result.

Any idea, expectation about the script/GA ? Any limitation to this current suggestion ?

@AbcSxyZ
Copy link
Contributor Author

AbcSxyZ commented Dec 15, 2021

Beginning of an implementation with PR #40 about Dockerfile templatization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant