Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor requirements #73

Open
6 of 8 tasks
doe300 opened this issue Jun 16, 2016 · 0 comments
Open
6 of 8 tasks

Refactor requirements #73

doe300 opened this issue Jun 16, 2016 · 0 comments
Milestone

Comments

@doe300
Copy link
Owner

doe300 commented Jun 16, 2016

Remove direct inclusion of opus and rtaudio or at least move into sub-projects,

  1. since they are not compulsory anymore
  2. so they don't bloat the repository
  3. so they can be updated seperately (and by the user)

Git subprojects would provide a backup if no libraries are available on the installation computer.

  • update CMake min version to a newer version supported by Travis CI and Appveyor (3.2)
  • Remove all files from git, commit and add subprojects
  • Make sure that libraries are still compatible (to be sure, use same librariy-versions as before)
  • Need to make sure that OHMComm compiles without the subprojects initialized
  • Optionally, modify CMake-script to automatically init subprojects, if no libraries were found. Possible?
  • Also update documentation of required libraries, optional or mandatory, what they are used for and where to get them. Add to Readme.
  • Add CMake to cryptopp (copy CMakeLists.txt from master similar to opus)
  • Fix compilation errors (use FORCE_CUSTOM_LIBRARIES for MSVC, since it doesn't find OpenSSL for some reason)

CMake ExternalProject_Add allows to download and build a git repo without specifying it as submodule. Which way is the better one?

Info here: https://chrisjean.com/git-submodules-adding-using-removing-and-updating/
https://github.com/psi4/psi4/wiki/External-subprojects-using-Git-and-CMake https://cmake.org/cmake/help/v3.0/module/ExternalProject.html

@doe300 doe300 added this to the Version 1.0 milestone Jun 16, 2016
@doe300 doe300 self-assigned this Jun 16, 2016
doe300 added a commit that referenced this issue Jul 1, 2016
doe300 added a commit that referenced this issue Jul 8, 2016
doe300 added a commit that referenced this issue Jul 8, 2016
@doe300 doe300 mentioned this issue Jul 15, 2016
6 tasks
@doe300 doe300 removed their assignment Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant