From 73e30df52bae96f54e583b72074e67094197f5af Mon Sep 17 00:00:00 2001
From: MatteoFeltrin <matteo.feltrin@kanbanbox.com>
Date: Tue, 14 May 2024 15:06:47 +0200
Subject: [PATCH] allow classname in 'value' attribute of xml
 discriminator-mapping field

---
 doctrine-mapping.xsd                             |  2 +-
 tests/Tests/Models/Customer/CustomerType.php     | 16 ++++++++++++++++
 tests/Tests/Models/Customer/ExternalCustomer.php | 13 +++++++++++++
 tests/Tests/Models/Customer/InternalCustomer.php | 13 +++++++++++++
 tests/Tests/ORM/Mapping/ClassMetadataTest.php    | 16 ++++++++++++++++
 ...ne.Tests.Models.Customer.CustomerType.dcm.xml | 14 ++++++++++++++
 6 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 tests/Tests/Models/Customer/CustomerType.php
 create mode 100644 tests/Tests/Models/Customer/ExternalCustomer.php
 create mode 100644 tests/Tests/Models/Customer/InternalCustomer.php
 create mode 100644 tests/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.Customer.CustomerType.dcm.xml

diff --git a/doctrine-mapping.xsd b/doctrine-mapping.xsd
index a058787746c..651c9d29c09 100644
--- a/doctrine-mapping.xsd
+++ b/doctrine-mapping.xsd
@@ -375,7 +375,7 @@
     <xs:choice minOccurs="0" maxOccurs="unbounded">
       <xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
     </xs:choice>
-    <xs:attribute name="value" type="xs:NMTOKEN" use="required"/>
+    <xs:attribute name="value" type="orm:type" use="required"/>
     <xs:attribute name="class" type="orm:fqcn" use="required"/>
     <xs:anyAttribute namespace="##other"/>
   </xs:complexType>
diff --git a/tests/Tests/Models/Customer/CustomerType.php b/tests/Tests/Models/Customer/CustomerType.php
new file mode 100644
index 00000000000..bd68c07ecf2
--- /dev/null
+++ b/tests/Tests/Models/Customer/CustomerType.php
@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\Models\Customer;
+
+class CustomerType
+{
+    /** @var string */
+    public $name;
+
+    public function __construct(string $name)
+    {
+        $this->name = $name;
+    }
+}
diff --git a/tests/Tests/Models/Customer/ExternalCustomer.php b/tests/Tests/Models/Customer/ExternalCustomer.php
new file mode 100644
index 00000000000..cf50d3e85e0
--- /dev/null
+++ b/tests/Tests/Models/Customer/ExternalCustomer.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\Models\Customer;
+
+final class ExternalCustomer extends CustomerType
+{
+    public function __construct(string $name)
+    {
+        parent::__construct($name);
+    }
+}
diff --git a/tests/Tests/Models/Customer/InternalCustomer.php b/tests/Tests/Models/Customer/InternalCustomer.php
new file mode 100644
index 00000000000..305bdd140b9
--- /dev/null
+++ b/tests/Tests/Models/Customer/InternalCustomer.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\Models\Customer;
+
+final class InternalCustomer extends CustomerType
+{
+    public function __construct(string $name)
+    {
+        parent::__construct($name);
+    }
+}
diff --git a/tests/Tests/ORM/Mapping/ClassMetadataTest.php b/tests/Tests/ORM/Mapping/ClassMetadataTest.php
index 48079777276..fcd4cffc35f 100644
--- a/tests/Tests/ORM/Mapping/ClassMetadataTest.php
+++ b/tests/Tests/ORM/Mapping/ClassMetadataTest.php
@@ -13,6 +13,7 @@
 use Doctrine\ORM\Mapping\Column;
 use Doctrine\ORM\Mapping\DefaultNamingStrategy;
 use Doctrine\ORM\Mapping\DefaultTypedFieldMapper;
+use Doctrine\ORM\Mapping\Driver\XmlDriver;
 use Doctrine\ORM\Mapping\MappedSuperclass;
 use Doctrine\ORM\Mapping\MappingException;
 use Doctrine\ORM\Mapping\UnderscoreNamingStrategy;
@@ -24,6 +25,7 @@
 use Doctrine\Tests\Models\CMS;
 use Doctrine\Tests\Models\CMS\CmsEmail;
 use Doctrine\Tests\Models\Company\CompanyContract;
+use Doctrine\Tests\Models\Customer\CustomerType;
 use Doctrine\Tests\Models\CustomType\CustomTypeParent;
 use Doctrine\Tests\Models\DDC117\DDC117Article;
 use Doctrine\Tests\Models\DDC117\DDC117ArticleDetails;
@@ -1392,6 +1394,20 @@ public function testInvalidCallToGetAssociationMappedByTargetFieldIsDeprecated()
 
         $metadata->getAssociationMappedByTargetField('foo');
     }
+
+    public function testClassNameMappingDiscriminatorValue(): void
+    {
+        $driver     = new XmlDriver(
+            __DIR__ . '/xml',
+            XmlDriver::DEFAULT_FILE_EXTENSION,
+            true
+        );
+        $xmlElement = $driver->getElement(CustomerType::class);
+        self::assertEquals(
+            'Doctrine\Tests\Models\Customer\InternalCustomer',
+            $xmlElement->children()->{'discriminator-map'}->{'discriminator-mapping'}[0]->attributes()['value']
+        );
+    }
 }
 
 /** @MappedSuperclass */
diff --git a/tests/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.Customer.CustomerType.dcm.xml b/tests/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.Customer.CustomerType.dcm.xml
new file mode 100644
index 00000000000..8767e3220a8
--- /dev/null
+++ b/tests/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.Customer.CustomerType.dcm.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
+                  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
+                          https://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd">
+    <entity name="Doctrine\Tests\Models\Customer\CustomerType" table="customers" inheritance-type="SINGLE_TABLE">
+        <field name="name" column="name"/>
+        <discriminator-column name="type" type="string"/>
+        <discriminator-map>
+            <discriminator-mapping value="Doctrine\Tests\Models\Customer\InternalCustomer" class="Doctrine\Tests\Models\Customer\InternalCustomer" />
+            <discriminator-mapping value="Doctrine\Tests\Models\Customer\ExternalCustomer" class="Doctrine\Tests\Models\Customer\ExternalCustomer" />
+        </discriminator-map>
+    </entity>
+</doctrine-mapping>