Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - scrollable code region should be focusable #2224

Closed
1 task done
kburk1997 opened this issue Sep 12, 2023 · 1 comment · Fixed by #2264
Closed
1 task done

Accessibility - scrollable code region should be focusable #2224

kburk1997 opened this issue Sep 12, 2023 · 1 comment · Fixed by #2264
Assignees

Comments

@kburk1997
Copy link

kburk1997 commented Sep 12, 2023

Bug Report

Steps to reproduce

  1. Go to develop preview
  2. Scroll down until code samples are visible
  3. Shrink window size until scrollbars appear on code samples
  4. Run axe-devtools automated checker

Current behaviour

Axe-devtools produces the following issue:

Scrollable region must have keyboard access

Ensure elements that have scrollable content are accessible by keyboard

Element Info

Element location:

pre[data-lang="js"][v-pre=""]:nth-child(10) > .lang-js

Element source:

<code class="lang-js">

Screenshot
Screenshot of scrollable code snippet that is not focusable

About this issue:

Test Name: Docsify Preview
Test URL: https://docsify-preview.vercel.app/#/configuration?id=homepage
Impact: Serious
Found on: 9/12/2023 at 10:54 am
Found: Automatically
Issue tags: cat.keyboard, wcag2a, wcag211, TTv5, TT4.a
Help: Scrollable region must have keyboard access

Expected behaviour

Running axe-devtools should not produce the above error.

Code snippets should be scrollable so that keyboard-only users can read the code snippet's contents by scrolling.

Other relevant information

  • Docsify version: develop
  • Bug still occurs when all/other plugins are disabled?

  • Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue): none

@jhildenbiddle
Copy link
Member

Thanks for creating the issue, @kburk1997!

I've created a draft PR here: #2264. In that PR you will find a preview link which will allow you to review the changes:

CleanShot 2023-10-17 at 08 59 27@2x

Before I mark this PR as ready for review by the maintainers, I would love to get your thoughts and/or feedback.

Thanks!

@jhildenbiddle jhildenbiddle linked a pull request Nov 16, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants