Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docopt breaks lots of JS modules. #6

Open
robotlolita opened this issue May 4, 2013 · 3 comments
Open

Docopt breaks lots of JS modules. #6

robotlolita opened this issue May 4, 2013 · 3 comments

Comments

@robotlolita
Copy link

Due to Docopt manipulating native objects' prototypes, it breaks lots of modules that rely on the standard behaviour. Right now, it isn't safe to use Docopt with any other module, since those modules are likely to break.

This is related to #4, but broader.
@sonwell
Copy link
Contributor

sonwell commented May 8, 2013

Other than overwriting Array.toString, is there anything else?

@brettlaforge
Copy link

+1

sequelize.js - broken due to messing with Array.toString

@jimfleming jimfleming mentioned this issue May 12, 2014
Closed
kemitchell pushed a commit to kemitchell/docopt.coffee that referenced this issue Jul 1, 2017
@stuartcarnie
Merge pull request docopt#6 from amtrack/options_first
a4fac2f 
options_first
@nickserv
Copy link

I think this is fixed now, it's not defining or extending Array directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sonwell @brettlaforge @robotlolita @nickserv