UrlControl issue: cannot upload for any role (Only works for admin/Superuser)

[erw13n]

Description of bug

Upgraded to DNN 9.11
Form & List module still using UrlControl on one of their field, and it seems there's an issue on field with type "URL".
It doesn't allow users who is not "Admin" or "Superuser" to Upload file.

This is not an issue with Form & List module, because the issue within UrlControl
It happen even if the User Role have "Browse, View & Write" permission to folder.
Whenever press "Upload New File" it throw error "You don't have permission to upload files to this site."
This is not happen for "Admin" or "Superuser"

After browsing through the source code, this line seems check if user has "ADD" permission on the folder

Dnn.Platform/DNN Platform/Library/UI/UserControls/URLControl.cs

Line 923 in c7b0465

this.LoadFolders("ADD");

Don't know if this is the cause of the issue.
But somehow it always throw "You don't have permission to upload files to this site." on every folder, even if it was "My Folder"

I check table "Permission" and I don't see any PermissionKey "ADD" for SYSTEM_FOLDER, it only have "READ, WRITE & BROWSE"

So whenever it call SP GetFoldersByPermissions it always return NULL, because there's no "ADD" permission.

Steps to reproduce

1. Using "Form & List" module, create a new form
2. At least one field type set to "URL"
3. Set module permission "Create Record/ Submit Form" for certain role
4. Set the same role to have "Browse, View & Write" permission to folder.
5. "Add new Record", and change Link Type to "File", change folder and press "Upload new file"
6. It throw "You don't have permission to upload files to this site." immediately

[MaiklT]

This seems to be an issue of the UrlControl - I have the same behaviour in the Links and Documents module.

[erw13n]

I just notice that the old Digital Assets Management 9.8.1 had Add Permission in it:

[skamphuis]

Found this too. Submitting a PR for it.

The issue is that the URLControl tries for "ADD" permission on the selected folder, but that doesn't exist (anymore?). It should be "WRITE" instead.

[skamphuis]

Also: U bent niet bevoegd om bestanden te uploaden. in DNNCommunity/DNN.Documents