Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint report when score is misssing #12153

Open
khurtado opened this issue Oct 21, 2024 · 1 comment
Open

Fix pylint report when score is misssing #12153

khurtado opened this issue Oct 21, 2024 · 1 comment

Comments

@khurtado
Copy link
Contributor

khurtado commented Oct 21, 2024

Impact of the bug
Jenkins reports (both in CC7 and CC9) can break under certain circumstances.

Jenkins setups:
CC7:
https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCore-PR-pylintpy3/

CC9:
https://cmssdt.cern.ch/dmwm-jenkins/view/WMCore%20Docker/job/WMCore-PR-pylint/

Describe the bug
The jenkins pylint json report sometimes misses the score, and the HTML report fails due to this.

How to reproduce it
Create a report with jenkins on PR:
#12123

The json pylint report created will be this:
https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCore-PR-pylintpy3/3471/artifact/pylintpy3Report.json/*view*/

As you can see, the first file is missing a "base" field. Other files do have the base field.
Here is another report that works fine for comparison:
https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCore-PR-pylintpy3/3480/artifact/pylintpy3Report.json/*view*/

The filename specifically in this PR with the issue is WorkflowUpdater.py

  "src/python/WMComponent/WorkflowUpdater/WorkflowUpdater.py": {
    "test": {
      "events": [

Expected behavior
Jenkins should produce an HTML report with the PR unit test changes and pylint reports.

Additional context and error message
Add any other context about the problem here, like error message and/or traceback. You might want to use triple back ticks to properly format it.

@khurtado
Copy link
Contributor Author

I added a fix in the CC9 test environment

khurtado/jenkins-test@16ea2ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant