Remove unused JSON encoding choice keywords #12141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Jenkins results:
|
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
|
Hello, @khurtado . Looking at the Jenkins logs here: https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCorePy3-PR-unittests/3530/SLICE=7,label=cms-dmwm-cc7/testReport/junit/WMCore_t.WorkQueue_t.WorkQueue_t/WorkQueueTest/testProductionMultiQueue/ , am I correct in thinking this shows the unit test was failing since #12151 ? Or was the code affected by this PR and succeeded by chance at least once between these two PRs? Or is this one of the unstable tests that can be ignored? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12137
Status
not-tested
Description
Remove this seemingly unused keyword, used to enumerate words to JSON-encode.
Let's test it and see if somehow it still does something.
Is it backward compatible (if not, which system it affects?)
MAYBE
Related PRs
External dependencies / deployment changes