Set memory for ignored tasks (Express Merge) #12085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinaresToine
commented
Aug 27, 2024
| @@ -2002,6 +2009,10 @@ def updateArguments(self, kwargs): | |||
|
|
|||
| if kwargs.get("Memory") is not None: | |||
| self.setMemory(kwargs.get("Memory")) | |||
| if kwargs.get("TaskMemory") is not None: | |||
There was a problem hiding this comment.
The configuration used from T0 side would have a feature named "TaskMemory"
|
Jenkins results:
|
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12086
Status
In development
Description
Currently, "Merge" tasks, among others, have their job resource information hardcoded in setRuntimeMonitors. For these tasks, the functions that set a different memory value do not work, as they are set to ignore such tasks:
The problem with this is that Express Merge jobs in particular have shown to need more memory than the default value of 2.3 GiB. Since the memory setting functions ignore merge tasks, these jobs cant be given more memory without changing the current code.
This patch allows to avoid the tasks from being ignored in case a task is specified
Adds support for setting the memory of specified taskNames, and if such taskName is of a "Merge" task it would not be ignored.
Is it backward compatible (if not, which system it affects?)
MAYBE
Related PRs
NONE
External dependencies / deployment changes
NONE