-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input range + filter + chain => First element vanishes #9877
Labels
Comments
Inkrementator
added a commit
to Inkrementator/phobos
that referenced
this issue
Feb 19, 2025
The constructor of the result of std.range.chain copies it's input tuple and then has to check which of the input-ranges in the first non-empty one. The member function empty is not guaranteed to be const, filter is probably the most prominent function that has to be "primed". On the first call to empty(), filter will try to advance all it's input ranges to the first element that matches the predicate. For ranges with full value semantics, using the old input object instead of the new internal buffer means that the work of priming is done twice. If any ranges have reference semantics, the references gets advances, but the value-semantic parts of the range-composition gets reset. This fixes dlang#10561 and dlang#9877
thewilsonator
pushed a commit
that referenced
this issue
Feb 19, 2025
The constructor of the result of std.range.chain copies it's input tuple and then has to check which of the input-ranges in the first non-empty one. The member function empty is not guaranteed to be const, filter is probably the most prominent function that has to be "primed". On the first call to empty(), filter will try to advance all it's input ranges to the first element that matches the predicate. For ranges with full value semantics, using the old input object instead of the new internal buffer means that the work of priming is done twice. If any ranges have reference semantics, the references gets advances, but the value-semantic parts of the range-composition gets reset. This fixes #10561 and #9877
Fixed by #10643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
qigezx+dc40d6nao940k reported this on 2024-09-20T12:56:08Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=24774
Description
The text was updated successfully, but these errors were encountered: