New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is checkRatios test valid? #4

Open

Svenny opened this issue Aug 3, 2018 · 1 comment

Contributor

Svenny commented Aug 3, 2018 •

edited

Loading

Look at test.cpp, lines 80-81:

int counts[] = {3, 3, 10, 2, 3};
CHECK_EQ(checkRatios(&counts[0]), true);

This data clearly doesn't fit the intended 1:1:3:1:1 pattern, but is marked as valid. Is this an error in test case?

The text was updated successfully, but these errors were encountered:

Owner

dkurt commented Aug 6, 2018

@Svenny, This is just a sample which can be faced in real images. Actually, it's just a test for your threshold value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment