-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset counts as input #10
Comments
I'd like to add a second use case for this. I use node as a "gate" with the My trouble is there is a way for the upstream logic to send "reset" twice, which should just "keep the throttle open" but instead actually triggers the throttle on the second "reset" message. In my opinion, all "reset" messages should not be passed through or count as an input message. |
I think both cases could be solved by flipping the // throttle by reset
else if( node.throttleType === "reset" ) {
if( !node.reset ) {
node.reset = true;
node.send(msg);
}
else if( msg.reset ) {
node.reset = false;
}
}
// CHANGE TO:
// throttle by reset
else if( node.throttleType === "reset" ) {
if( msg.reset ) {
node.reset = false;
}
else if( !node.reset ) {
node.reset = true;
node.send(msg);
}
} |
Hi, I have an issue with this node. I set it up using "by block size" using 3.
Now it works perfectly when I inject let's say 15 messages. only the first 3 passes through. and when I reset it discards of the rest... Perfect.
But if you by accident inject reset twice, the second reset counts as one of the messages and it only passes through 2 of the messages.
Is there a way to block the reset to count as a message when injecting it more than once.
The reset in my case is a touch button on a 3.5inch LCD hat. so for a person to reset twice or three times is normal. especially if you don't know that the reset went through.
The text was updated successfully, but these errors were encountered: