Added writeStream support for uploadSession #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed promise execution
dkatavic
reviewed
Sep 20, 2020
| } | ||
| params.readableStream.resume(); | ||
| }).catch(e => { | ||
| console.log('err') |
dkatavic
reviewed
Sep 20, 2020
| */ | ||
|
|
||
| function uploadSession(params, progress = () => {}) { | ||
| function uploadSession(params, progress, writeStream, cb) { |
There was a problem hiding this comment.
progress is failing for me as it is required now. If you rebase from master it will default to progress = () => {} and wont break existing code
|
This looks great, thanks! Would you mind writing an e2e test for a writable stream? There is a documentation for e2e tests (lacking) here ./test and example from @namdien177 #29 I can help you out with writing it (or write it if you are stuck / out of free time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28