Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload writeStream #28

Open
steffanhalv opened this issue Aug 20, 2020 · 3 comments · May be fixed by #31
Open

Upload writeStream #28

steffanhalv opened this issue Aug 20, 2020 · 3 comments · May be fixed by #31

Comments

@steffanhalv
Copy link
Collaborator

.uploadSession should return a write stream instead of / or in addition to having a callback.

This will make it easier to work with piping of readStreams, ex. to integrate with multer.

@dkatavic
Copy link
Owner

Hi @steffanhalv , are you still interested in building this

@steffanhalv
Copy link
Collaborator Author

Sorry, it already works. Only thing remains is the e2e test which I dont have time for.

@dkatavic
Copy link
Owner

That is cool, I will try to make time for it during the holidays 👍 . Thanks for contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants