Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services are bad for low level flight control, Topics needed #505

Open
xaedes opened this issue Jun 22, 2022 · 5 comments
Open

Services are bad for low level flight control, Topics needed #505

xaedes opened this issue Jun 22, 2022 · 5 comments

Comments

@xaedes
Copy link

xaedes commented Jun 22, 2022

Previously it was possible to set low level flight controller target via topics.
Now this seems to be entirely replaced by services.

This may make sense for high level control.
But an RPC for low level control, like drone velocity, is just too much.
The response result is irrelevant and you want high throughput with minimal latency and overhead.

Services only add overhead here and also make it impossible to record sent flight commands with rosbag.

It really is big step backwards.

@snakehaihai
Copy link

maybe that's what they want. I haven`t switched to 4+ yet. Still using 3.9 for this very reason :) . I only tried 4 with high level waypoint control. If you a researcher, then stay at 3.9.

@xaedes
Copy link
Author

xaedes commented Sep 8, 2022

I now just added Flight Control via topic.

Last year we had the same problem for gimbal control, where we wanted it to smoothly follow a tracked target. With the service based control it was super choppy and barely useable at all. Right after switching to topic based control it was as smooth as a polished marble ball.

xaedes@a269123

@snakehaihai
Copy link

well belive it or not. most people are moving back to pixhawk for this very reason. https://www.youtube.com/watch?v=MxeoKVXrmEs&ab_channel=MARSLABHKU

image

@Threepain
Copy link

I really agree with your suggestion. Some low-level flight control commands can be released through topic. Maybe Payload-SDK is what DJI really wants us to use, the last update of Onboard-SDK-ROS was two years ago (:D).

@snakehaihai
Copy link

I really agree with your suggestion. Some low-level flight control commands can be released through topic. Maybe Payload-SDK is what DJI really wants us to use, the last update of Onboard-SDK-ROS was two years ago (:D).

Don't get to the psdk 3.3 series ... that shit is missing tons of cmakelist and no ros interface. Basically, there is only one demo which is connecting to the drone. Need video feed? ok put in cmake urself and make hardware connector yourself. Need quite a lot of development to make it workable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants