Bug in exclude() using contains

[jmbowman]

I have a query that includes a condition like the following:

.exclude(hstore_field__contains={'key_name': 'value'})

In django-hstore 1.3.4 and earlier, this translated to the following SQL:

WHERE NOT ("app_model"."hstore_field" @> hstore(ARRAY['key_name'], ARRAY['value']) AND "app_model"."hstore_field" IS NOT NULL)

But starting in 1.3.5, it changed to the following:

WHERE NOT (("app_model"."hstore_field"->'key_name') = 'value' AND "app_model"."hstore_field" IS NOT NULL)

The latter breaks down when the hstore field is not null but doesn't contain the key. It simplifies as follows:

WHERE NOT (NULL = 'value' AND TRUE)
WHERE NOT (NULL AND TRUE)
WHERE NOT NULL
WHERE NULL

Hence the condition ultimately evaluates as false and the record is excluded, even though we were trying to get records like this one that don't contain the specified key/value combination. The SQL from earlier versions works correctly, because it doesn't throw a NULL into the boolean operations.

[dannosaur]

Yea, I'm seeing this as well. Trying to exclude records that have a specific key in the dictionary isn't yielding any rows at all. I'm using django_hstore 1.4.2.

[andrewhayes1979]

+1