Codecov Report

Merging #85 into master will decrease coverage by 3.93%.
The diff coverage is 1.72%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   75.95%   72.02%   -3.94%     
==========================================
  Files          26       26              
  Lines         549      579      +30     
==========================================
  Hits          417      417              
- Misses        132      162      +30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6dadb7...bd62c59. Read the comment docs.

Hi friend! Thanks for the PR! I'm not going to be able to review it, though, because the diff is a bit of a mess :)

It seems you are PR'ing against the releases/1.0.x which is a stable release branch, i.e. new features wouldn't go into this branch, anyways. Could you perhaps have a look at the master branch where new development should take place?

Thanks :)

Okay, I've changed the base branch, that seems to work -- @yevheniidehtiar could you confirm if the diff looks as intended?

Hi, yes the diff looks right 👍 Thank you man)

@yevheniidehtiar would you be able to resolve the conflicts, and then we can check if tests are running?

@yevheniidehtiar A lot of great work here, looking forward to seeing it merged :) Could you start by merging the current master of this repository into your branch? This will lead to some merge conflicts that I don't think look very complicated.

I'm a bit hesitant to make changes in your branch since it's your master branch and I assume you might be using it for something?

Ok, man. When I will have free time for this. I merge and create new pull request with my new updates, like messaging over websocket between two clients and bug-fixes with async methods.

Thank you man
Ok, man

Was re-reading the salutations in this PR 😄

Since today is indeed the International Men's Day, I thought to just quick ask and encourage that your work on this isn't forgotten - but that you are most welcome to resolve the conflicts and we'll get this in! 🙏

Hi guys, seems i forgot it couple years ago and gonna to finish it soon)

That sounds great, am hear to help resolve decisions and get things merged, much appreciated to have this PR finished 👍

Hi @yevheniidehtiar 👋

Time flies :)

A lot of work went into this, I was wondering if you could share some background on this PR? Do you have a project that's already running this code? And if so, does it work well?

Hi @yevheniidehtiar 👋

Time flies :)

A lot of work went into this, I was wondering if you could share some background on this PR? Do you have a project that's already running this code? And if so, does it work well?

Hi @benjaoming

Yeap, time flies! Children grows :)

Django is already version 3 and soon 4.
I had a project in 2019 where this code was working very well.

Have no visible space in the agenda. It might be that it's gonna be updated again when I got a reason to use it.

@yevheniidehtiar yes, I recognize this time issue very well :)

It's nice to hear that the code is actually in a production setting, so without having reviewed it, I can assume that it's useful. I think we should keep the PR open for someone else to notice.

Closed as you already updated to channels 4 :)