Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal server error when clicking on "Settings"-button. #430

Open
jrief opened this issue Oct 21, 2024 · 1 comment
Open

Internal server error when clicking on "Settings"-button. #430

jrief opened this issue Oct 21, 2024 · 1 comment

Comments

@jrief
Copy link
Contributor

jrief commented Oct 21, 2024

How to reproduce:

  • Create a customized page content admin inheriting from PageContentAdmin.
  • In method get_fieldsets, add some extra fields part of your page content extension model.
  • Open a page with more than one version.
  • From the toolbar, open the dialog to "Manage Versions…".
  • Locate an unpublished version and click on the "Settings"-Button.

This will raise a ValueError in cms_config.py:283 stating that list.remove(x): x not in list.

The problem could be easily fixed by checking if f_name is member of fields.

Shall I create a pull request for this? I however don't know how to create a test for it.

@fsbraun
Copy link
Member

fsbraun commented Oct 23, 2024

@jrief Thank you for offering a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants