Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: The option 'cancel changes' within Versioning menu opens up direct and not in popup #336

Open
svandeneertwegh opened this issue May 31, 2023 · 1 comment
Open

BUG: The option 'cancel changes' within Versioning menu opens up direct and not in popup #336

svandeneertwegh opened this issue May 31, 2023 · 1 comment
Assignees
@svandeneertwegh

Comments

@svandeneertwegh
Copy link
Contributor

svandeneertwegh commented May 31, 2023 •
edited
Loading

Small bug.

When clicking on 'Cancel changes' here in NL translation it opens direct and not in a popup.

Schermafbeelding 2023-05-31 om 16 05 44

This issue found with the following setup:

django-cms==4.1.0rc3
djangocms-versioning==2.0.0rc1
djangocms-alias==2.0.0rc1
@fsbraun fsbraun moved this to Done in DjangoCon Europe Jun 1, 2023
@fsbraun fsbraun moved this from Done to Todo in DjangoCon Europe Jun 1, 2023
@fsbraun fsbraun moved this from Todo to In Progress in DjangoCon Europe Jun 1, 2023
@fsbraun
Copy link
Member

fsbraun commented Oct 30, 2023

@svandeneertwegh Can I interest you in creating a PR? :-)

svandeneertwegh added a commit to svandeneertwegh/djangocms-versioning that referenced this issue Oct 31, 2023
@svandeneertwegh
django-cms#336 bugfix from link_menu_item to modal_menu_item: discard…
a126f61 
… changes link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svandeneertwegh svandeneertwegh

Labels
None yet
Projects
No open projects
DjangoCon Europe
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fsbraun @svandeneertwegh