You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using django-cms together with versioning it's important to keep apart content/objects that should be displayed to the end user and content/objects that can be viewed by an admin user.
get_title_obj is used in several places to assign the object both in toolbars (admin related) and in places that will render to the end user.
There has been a lot of monkeypatching going on in djangocms-versioning to account for this fact. By creating a method get_admin_title_obj this method alone could be monkeypatched instead of spreading out the monkeypatching. If/when versioning is incorporated into core it would also make things easier to incorporate any monkeypatches into this method.
This will also start to setup us up for a clean separation between what is viewable by admin users and what is viewable by end users.
This is also related to the following PR > django-cms/django-cms#6817 instead of that implementation it would be better if it used get_admin_title_obj
The text was updated successfully, but these errors were encountered:
jonathan-s
changed the title
Refactor get_title_obj in django-cms
Refactor get_title_obj in django-cms
Mar 11, 2020
When using django-cms together with versioning it's important to keep apart content/objects that should be displayed to the end user and content/objects that can be viewed by an admin user.
get_title_obj
is used in several places to assign the object both in toolbars (admin related) and in places that will render to the end user.There has been a lot of monkeypatching going on in djangocms-versioning to account for this fact. By creating a method
get_admin_title_obj
this method alone could be monkeypatched instead of spreading out the monkeypatching. If/when versioning is incorporated into core it would also make things easier to incorporate any monkeypatches into this method.This will also start to setup us up for a clean separation between what is viewable by admin users and what is viewable by end users.
This is also related to the following PR > django-cms/django-cms#6817 instead of that implementation it would be better if it used
get_admin_title_obj
The text was updated successfully, but these errors were encountered: