remove Cargo.lock from gitignore and commit it

[quantenzitrone]

https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

The purpose of a Cargo.lock lockfile is to describe the state of the world at the time of a successful build. Cargo uses the lockfile to provide deterministic builds at different times and on different systems, by ensuring that the exact same dependencies and versions are used as when the Cargo.lock file was originally generated.

your .gitignore even says:

Remove Cargo.lock from gitignore if creating an executable, leave it for libraries

[quantenzitrone]

also point your two dependencies on local directories to the respective online repos so others can build it without having to go searching for these

[dividebysandwich]

Hi,
Roger on the Cargo.lock file. However, I can't seem to add the git url for my forked dnglab because I use rawler which is in a subdirectory, and Cargo does not seem to be able to pick up on that. I cannot specify git and path at the same time either.

warning: unused manifest key: package.website
Updating git repository `https://github.com/dividebysandwich/imagepipe`
Updating git repository `https://github.com/dividebysandwich/dnglab`
error: no matching package named `rawler` found
location searched: https://github.com/dividebysandwich/imagepipe#2bdc49e8

This is with the following in Cargo.toml:

imagepipe = { git = "https://github.com/dividebysandwich/imagepipe" }
rawler = { git = "https://github.com/dividebysandwich/dnglab" }

[quantenzitrone]

that is weird
another solution would be adding them as submodules

[dividebysandwich]

Maybe, but I'd like to keep the repos separate so they're easier to maintain and keep up with upstream. I'm not sure why it can't find rawler. I suspect it's not even looking in dnglab, since the error message lists only imagepipe as "locations searched"...

[quantenzitrone]

When I try it, the problem is that your fork of imagepipe also depends on a local repository of rawler.
So you'd have to fix that first.

error: no matching package named rawler found
location searched: https://github.com/dividebysandwich/imagepipe#2bdc49e8
required by package imagepipe v0.5.0 (https://github.com/dividebysandwich/imagepipe#2bdc49e8)
... which satisfies git dependency imagepipe of package lightningview v1.8.0 (/data/documents/programming/github.com/LightningView)