Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keys to be specified using globs/pattern matching #12

Open
zgramana opened this issue Oct 19, 2015 · 1 comment
Open

Allow keys to be specified using globs/pattern matching #12

zgramana opened this issue Oct 19, 2015 · 1 comment

Comments

@zgramana
Copy link

We have some rather large and deeply nested expvars. As a user, I would love to use globs instead of commands like this:

./expvarmon -vars="cb.ops.Write(raw).count,cb.ops.Write(raw).p99,cb.ops.Write(raw).p95,cb.ops.Write(raw).p90,cb.ops.Write(raw).p75,cb.ops.Write(raw).p50,cb.ops.Write(raw).p25"

For example, it would be great to instead be able to simply type:

./expvarmon  -vars="cb.ops.Write(raw).*"

or even

./expvarmon  -vars="cb.ops.*"
@divan
Copy link
Owner

divan commented Oct 29, 2015

Hi Zachary. Current design is based on fixed list of vars names, UI is being constructed before vars are fetched.
Refactoring to support wildcards is probably viable, but it adds a number of complications that should be addressed and solved right. UI should be (re)arranged on each json parse, service downtimes should be handled differenly (if UI depends on each JSON data blob), etc.

I'll think about it, but not promising a quick solution. Meanwhile, if you're up to solve this gracefully, PR is always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants