Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sync tasks (and command traits) to separate package #4

Open
daften opened this issue Mar 23, 2017 · 3 comments
Open

Extract sync tasks (and command traits) to separate package #4

daften opened this issue Mar 23, 2017 · 3 comments
Assignees

Comments

@daften
Copy link
Contributor

daften commented Mar 23, 2017

E.g. protected function syncTask(), public function digipolisSyncLocal()

New package name robo-digipolis-sync

@Jelle-S Jelle-S self-assigned this Mar 24, 2017
@Jelle-S
Copy link
Collaborator

Jelle-S commented Mar 27, 2017

Might be more work than I anticipated initially.

Both the sync and the deploy tasks use the backup tasks, which means we'd have to create an additional package for the backup tasks.

Also the backup, sync and deploy tasks all depend on the getRemoteSettings method, which means we'd have to extract that as well. Although consolidation/robo#552 might be a big help here...

@daften
Copy link
Contributor Author

daften commented Mar 27, 2017

Let's at least wait until that PR is merged, and see what refactors might follow after that.

@greg-1-anderson
Copy link

n.b. consolidation/robo#552 now supports injecting default values for task setter methods from configuration. You should review that PR and the associated documentation it contains to see if it meets your use-case for configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants