Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update sbt in the project and scripted tests #1538

Open
kubukoz opened this issue May 23, 2024 · 4 comments · May be fixed by #1580
Open

Chore: update sbt in the project and scripted tests #1538

kubukoz opened this issue May 23, 2024 · 4 comments · May be fixed by #1580
Labels
good first issue Good for newcomers

Comments

@kubukoz
Copy link
Member

kubukoz commented May 23, 2024

In the build.properties scattered around the codebase, update sbt.version to whatever the latest stable version is (at time of writing, 1.10.0).
@kubukoz kubukoz added the good first issue Good for newcomers label May 23, 2024
@Baccata
Copy link
Contributor

Baccata commented May 24, 2024

I'd like it if we could sync the version of SBT used in scripted tests with what's actually used by the build. Any idea how we could do this ? It's not like we can use the usual "build-info" trick.

@kubukoz
Copy link
Member Author

kubukoz commented May 24, 2024

Can we modify the scripted task to first iterate over these directories and update if needed?

@Baccata
Copy link
Contributor

Baccata commented May 24, 2024

possibly

@kubukoz
Copy link
Member Author

kubukoz commented Sep 6, 2024

I think we could also just delete build.properties in the test directories and it'll automatically use the "parent" sbt's version. That should be optimal.

@kubukoz kubukoz linked a pull request Sep 6, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update sbt to 1.10 disneystreaming/smithy4s
2 participants
@kubukoz @Baccata