From d493359518d6200d5fe7dbc6f9b930b5f525bcf8 Mon Sep 17 00:00:00 2001 From: Nat Date: Tue, 15 Aug 2023 13:38:56 +0800 Subject: [PATCH] Bump to two hours --- app/jobs/scheduled/enqueue_reminders.rb | 2 +- spec/jobs/scheduled/enqueue_reminders_spec.rb | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/jobs/scheduled/enqueue_reminders.rb b/app/jobs/scheduled/enqueue_reminders.rb index 02e982cd..3e9596ef 100644 --- a/app/jobs/scheduled/enqueue_reminders.rb +++ b/app/jobs/scheduled/enqueue_reminders.rb @@ -20,7 +20,7 @@ def allowed_group_ids Group.assign_allowed_groups.pluck(:id).join(",") end - REMINDER_BUFFER_MINUTES = 60 + REMINDER_BUFFER_MINUTES = 120 def user_ids global_frequency = SiteSetting.remind_assigns_frequency diff --git a/spec/jobs/scheduled/enqueue_reminders_spec.rb b/spec/jobs/scheduled/enqueue_reminders_spec.rb index 76de92da..bb193495 100644 --- a/spec/jobs/scheduled/enqueue_reminders_spec.rb +++ b/spec/jobs/scheduled/enqueue_reminders_spec.rb @@ -52,7 +52,8 @@ user.custom_fields[ PendingAssignsReminder::REMINDERS_FREQUENCY ] = RemindAssignsFrequencySiteSettings::DAILY_MINUTES - user.custom_fields[PendingAssignsReminder::REMINDED_AT] = 1.days.ago + 59.minutes + user.custom_fields[PendingAssignsReminder::REMINDED_AT] = 1.days.ago + + (Jobs::EnqueueReminders::REMINDER_BUFFER_MINUTES - 1) user.save assign_multiple_tasks_to(user, assigned_on: 2.day.ago) @@ -61,7 +62,10 @@ end it "does not enqueue a reminder if it's too soon" do - user.upsert_custom_fields(PendingAssignsReminder::REMINDED_AT => 1.days.ago + 60.minutes) + user.upsert_custom_fields( + PendingAssignsReminder::REMINDED_AT => + 1.days.ago + Jobs::EnqueueReminders::REMINDER_BUFFER_MINUTES, + ) assign_multiple_tasks_to(user) assert_reminders_enqueued(0)