Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Visualize page" makes many unencrypted requests to wrong sites #392

Open
123quhiwiwk opened this issue Dec 29, 2023 · 0 comments
Open

"Visualize page" makes many unencrypted requests to wrong sites #392

123quhiwiwk opened this issue Dec 29, 2023 · 0 comments

Comments

@123quhiwiwk
Copy link

When using the visualize page feature the addon tries to download the favicons of the sites.
But requests are sent to non-existent/other sites. And it tries to load the icon unencrypted via HTTP.
For example to http://www.com/favicon.ico and https://com/favicon.ico, see the following image:
Requests to www.com and com using HTTP

The problem seems to be this line, as it does not work as expected when the site uses no subdomain or with TLDs like ".co.uk".

The cause for HTTP loading and both requests to www.com and com are these lines:

var protocols = ['http://'];
var subdomains = ['', 'www.'];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant