Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

press.single-script should rename file #28

Open
sauravshah opened this issue May 17, 2012 · 7 comments
Open

press.single-script should rename file #28

sauravshah opened this issue May 17, 2012 · 7 comments

Comments

@sauravshah
Copy link

press.single-script uses the file name supplied - which does not invalidate cache when the contents change. Should append the hash to the file name.

@dirkmc
Copy link
Owner

dirkmc commented May 17, 2012

The cache control headers returned with the file should take care of this, is it not working for you?

@sauravshah
Copy link
Author

Nah. I had to rename the file manually to burst browser cache.

@dirkmc
Copy link
Owner

dirkmc commented May 17, 2012

I'm fairly busy this week but I'll try to take a look at it next week

@sauravshah
Copy link
Author

Putting this back into your radar :)

@dirkmc
Copy link
Owner

dirkmc commented May 24, 2012

Sorry you're right, I dropped the ball on this. I'm actually moving to Europe for the summer on Monday, so things are kind of crazy this week getting everything packed up. I should have more time next week, apologies for the delay.

@sauravshah
Copy link
Author

No problem dirkmc. I should be thanking you for this plugin :)
Take a look at the issue when you get time.

@dirkmc
Copy link
Owner

dirkmc commented Jun 12, 2012

I've pushed a fix and updated the module on playframework.org.
Sorry about the delay, please try it out and let me know how you go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants